This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Allow return value of HTTP redirection block to be NULL #3975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Can you merge in |
SlaunchaMan
approved these changes
Jul 13, 2017
* Make tests pass again * Fix macOS builds in Fastlane.
|
Done! :) |
Codecov Report
@@ Coverage Diff @@
## master #3975 +/- ##
==========================================
- Coverage 87.44% 86.95% -0.49%
==========================================
Files 45 45
Lines 6227 5505 -722
Branches 416 439 +23
==========================================
- Hits 5445 4787 -658
+ Misses 779 715 -64
Partials 3 3
Continue to review full report at Codecov.
|
|
@jshier This should be good to merge! |
|
@SlaunchaMan Any idea why the diff is showing cert changes? Otherwise it looks good. |
|
I’m pretty sure that’s just from |
viennhn
pushed a commit
to viennhn/AFNetworking
that referenced
this pull request
Aug 21, 2017
…tworking#3975)" This reverts commit dd59ffa.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses https://github.com/AFNetworking/AFNetworking/issues/3974