This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Added deprecated attribute to dataTaskWithRequest:completionHandler:
#3490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchohfi
changed the title
|
@kcharwood what you think about that? |
kcharwood
changed the title
dataTaskWithRequest:completionHandler:
|
which one is preferred? Thx! |
|
hey @zhw511006, you should be using the new one, as the method isn't called internally. The method is marked as deprecated to prevent subclasses from overriding it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's dangers to leave
dataTaskWithRequest:completionHandler:method without deprecated mark, as this method is now overloaded, and calling a different one, it breaks compatibility with previous overridden methods.