This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Updates AFHTTPSessionManager documentation to reflect v3.x changes
#3476
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… convenience methods.
ecaselles
changed the title
AFHTTPSessionManager documentation to reflect latest changesAFHTTPSessionManager documentation to reflect v3.x changes
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #3412.
The documentation on
AFHTTPSessionManager, Methods to Override section states that...But that is no longer accurate, since these convenience methods now go through the new
dataTaskWithRequest:uploadProgress:downloadProgress:completionHandler:. Therefore, overridingdataTaskWithRequest:completionHandler:will have no effect since it will never be called.This PR updates the documentation to reflect the fact that the method to override is now
dataTaskWithRequest:uploadProgress:downloadProgress:completionHandler:.