Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Fixed crash if bad URL was passed into the image downloader #3385

Merged
merged 2 commits into from
Mar 14, 2016
Merged

Fixed crash if bad URL was passed into the image downloader #3385

merged 2 commits into from
Mar 14, 2016

Conversation

kcharwood
Copy link
Contributor

A continuation of #3356 and #3343

xianwenx and others added 2 commits March 14, 2016 08:50
@xianwenx @kcharwood
Prevent crash when "AFImageDownloader identifier" is nil (which is ca…
fa2c806 
…use by passing an NSURLRequest which doesn't return an absoluteString). #3343. Added a test for this behavior.
@kcharwood
Refactored to dispatch an error if a bad URL is passed in.
ac6ba45
@kcharwood kcharwood added this to the 3.1.0 milestone Mar 14, 2016
@codecov-io
Copy link

Current coverage is 76.15%

Merging #3385 into master will decrease coverage by -0.10% as of 95fd8bc

@@            master   #3385   diff @@
======================================
  Files            5       5       
  Stmts         2489    2491     +2
  Branches         0       0       
  Methods                          
======================================
- Hit           1898    1897     -1
  Partial          0       0       
- Missed         591     594     +3

Review entire Coverage Diff as of 95fd8bc

Powered by Codecov. Updated on successful CI builds.

kcharwood added a commit that referenced this pull request Mar 14, 2016
@kcharwood
Merge pull request #3385 from AFNetworking/bug/fix_image_downloader_c…
32cf30a 
…rash_with_bad_url

Fixed crash if bad URL was passed into the image downloader
@kcharwood kcharwood merged commit 32cf30a into master Mar 14, 2016
@kcharwood kcharwood deleted the bug/fix_image_downloader_crash_with_bad_url branch March 14, 2016 18:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug fixed uikit extensions
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kcharwood @codecov-io @xianwenx