Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Removed workaround for NSJSONSerialization bug that was fixed in iOS 7 #3253

Merged
merged 3 commits into from
Jan 5, 2016
Merged

Removed workaround for NSJSONSerialization bug that was fixed in iOS 7 #3253

merged 3 commits into from
Jan 5, 2016

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented Dec 29, 2015

The NSJSONSerialization bug with Unicode character escape codes has been fixed in iOS 7, see http://openradar.appspot.com/radar?id=2397401#ag9zfm9wZW5yYWRhci1ocmRyFAsSB0NvbW1lbnQYgICAgIDdwwgM

Removing the NSData -> NSString -> NSData roundtrip is also likely a nice performance boost.

@codecov-io
Copy link

Current coverage is 73.91%

Merging #3253 into master will increase coverage by +0.08% as of 11d4934

@@            master   #3253   diff @@
======================================
  Files            5       5       
  Stmts         3027    3002    -25
  Branches         0       0       
  Methods                          
======================================
- Hit           2235    2219    -16
  Partial          0       0       
+ Missed         792     783     -9

Review entire Coverage Diff as of 11d4934

Powered by Codecov. Updated on successful CI builds.

@0xced 0xced force-pushed the remove-NSJSONSerialization-workaround branch from adbeccc to 3b5c4e8 Compare December 30, 2015 08:09
@0xced
Copy link
Contributor Author

0xced commented Dec 30, 2015

For reference, this workaround was introduced in #660.

0xced added 3 commits January 5, 2016 13:50
@0xced
Add tests for some AFJSONRequestSerializer corner cases (empty data)
d0ff538
@0xced
Refactor workaround single space in JSON deserialization
1d37329
@0xced
Remove workaround NSJSONSerialization bug
00e7a8b 
The NSJSONSerialization bug with Unicode character escape codes has been fixed in iOS 7, see http://openradar.appspot.com/radar?id=2397401#ag9zfm9wZW5yYWRhci1ocmRyFAsSB0NvbW1lbnQYgICAgIDdwwgM

Removing the NSData -> NSString -> NSData roundtrip is also likely a nice performance boost.
@0xced 0xced force-pushed the remove-NSJSONSerialization-workaround branch from 3b5c4e8 to 00e7a8b Compare January 5, 2016 12:50
@kcharwood kcharwood added this to the 3.1.0 milestone Jan 5, 2016
@kcharwood kcharwood changed the title Remove workaround NSJSONSerialization bug Removed workaround for NSJSONSerialization bug that was fixed in iOS 7 Jan 5, 2016
kcharwood added a commit that referenced this pull request Jan 5, 2016
@kcharwood
Merge pull request #3253 from 0xced/remove-NSJSONSerialization-workar…
9c7a3ab 
…ound

Removed workaround for NSJSONSerialization bug that was fixed in iOS 7
@kcharwood kcharwood merged commit 9c7a3ab into AFNetworking:master Jan 5, 2016
@kcharwood
Copy link
Contributor

🍻

@0xced 0xced deleted the remove-NSJSONSerialization-workaround branch January 5, 2016 14:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
removed response serializers
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@0xced @codecov-io @kcharwood