Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Exposed AFQueryStringFromParameters and AFPercentEscapedStringFromString for public use. #3160

Merged
merged 2 commits into from
Jan 5, 2016
Merged

Exposed AFQueryStringFromParameters and AFPercentEscapedStringFromString for public use. #3160

merged 2 commits into from
Jan 5, 2016

Conversation

kcharwood
Copy link
Contributor

I need custom AFHTTPRequestSerializer to feet for our api
case is :
in post request, some of url parameter must use url-formed format to apend in the url

so I need to use c method AFQueryStringFromParameters() but saw it is not open ,
can this be exposed in 3.0.0?

@kcharwood
Copy link
Contributor

I think this makes sense. We should expose that to make it easier.

@kcharwood kcharwood changed the title expose AFQueryStringFromParameters() Exposed AFQueryStringFromParameters for public use. Dec 15, 2015
@kcharwood kcharwood added this to the 3.1.0 milestone Dec 15, 2015
@kcharwood
Copy link
Contributor

I've attached a pull request exposing this behavior. Let me know what you think!

@codecov-io
Copy link

Current coverage is 69.87%

Merging #3160 into master will increase coverage by +0.10% as of 863b1f0

@@            master   #3160   diff @@
======================================
  Files            5       5       
  Stmts         3027    3027       
  Branches         0       0       
  Methods                          
======================================
+ Hit           2112    2115     +3
  Partial          0       0       
+ Missed         915     912     -3

Review entire Coverage Diff as of 863b1f0

Powered by Codecov. Updated on successful CI builds.

@kcharwood kcharwood changed the title Exposed AFQueryStringFromParameters for public use. Exposed AFQueryStringFromParameters and AFPercentEscapedStringFromString for public use. Dec 15, 2015
@BryanOne
Copy link
Author

👍 It's great, TKS~

kcharwood added a commit that referenced this pull request Jan 5, 2016
@kcharwood
Merge pull request #3160 from AFNetworking/feature/expose_query_strin…
c0e8cc0 
…g_helper

Exposed `AFQueryStringFromParameters` and `AFPercentEscapedStringFromString` for public use.
@kcharwood kcharwood merged commit c0e8cc0 into master Jan 5, 2016
@kcharwood kcharwood deleted the feature/expose_query_string_helper branch January 5, 2016 14:35
@0xced
Copy link
Contributor

0xced commented Jan 5, 2016

Don’t forget to bump next version to 3.1.0. According to Semantic Versioning:

7․ Minor version Y (x.Y.z | x > 0) MUST be incremented if new, backwards compatible functionality is introduced to the public API.

@kcharwood
Copy link
Contributor

Yep. Got this one targeted for the 3.1.0 milestone.

@liuchungui
Copy link

Very good，I want use it too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
added feature request request serializers
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@kcharwood @codecov-io @BryanOne @0xced @liuchungui