Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account System + Tailwind Implementation #96

Merged
merged 92 commits into from
Oct 24, 2023
Merged

Account System + Tailwind Implementation #96

merged 92 commits into from
Oct 24, 2023

Conversation

noahcussatti
Copy link
Contributor

Account System Implementation

Created basic user account system with registration, login, and page restrictions. Also implemented admin page for database management as well as a basic profile management page with the ability to change one's password.

Tailwind Implementation

  • Removed bootstrap
  • Added Tailwind CSS and Flowbite
  • Refactored all template pages
  • Implemented Django component
  • Created components for 'field', 'button', 'input', and 'popup'
  • Cleaned up codes
  • Bug fixes
  • Added background wave animation
  • Basic redesign of all views

RuikangRPI and others added 30 commits September 19, 2023 17:02
@RuikangRPI
installed tailwind
97287c6
@noahcussatti
Merge branch 'main' into Tailwind
7489e82
@noahcussatti
feat: Implemented Tailwind
d156707 
- Implemented tailwindcss for UI design
- Added docker-compressor to requirements as it's needed for tailwind
@noahcussatti
linting fixes
3f55fb7
@noahcussatti
Update settings.py
d6f5cae
@noahcussatti
Added django-compressor
05c7a66
@RuikangRPI
navbar revamp
0b192b5 
- removed bootstrap
- revamped navbar using tailwind
@noahcussatti
Merge branch 'main' into Tailwind
eda0f9a
@noahcussatti
feat: Implemented Django components
c1de76c 
- Many pages are still broken, but will be fixed soon
@matthewglanz
Created new registration form
e1804f4
@matthewglanz
Added customizable registration form
0bade48
@noahcussatti
Merge branch 'main' into Tailwind
e9f03e2
@matthewglanz
Added login page for registration verification
f8e0061
@matthewglanz
Added login navbar item and redirect to home
5ea61bb
@noahcussatti
feat: Implemented select field
0d3e460
@noahcussatti
feat; Finished tailwind page templates/components
974dfe1
@noahcussatti
Linting errors
b72ba73
@noahcussatti
More linting
5aa41b2
@noahcussatti
Update select.py
683ef4e
@matthewglanz
Enabled Admin View
8e5b81a
@matthewglanz
Added relevant admin models
3a61fa8
@RuikangRPI
upload
80736b5 
- wave animation
- if search result is empty render no results
@noahcussatti
added temporary navbar
d4532c1
@matthewglanz
Added secure superuser credentials and logout
3d5e8b8
@matthewglanz
Added placeholder profile page, extended navbar to new pages
9e4a8a6
@matthewglanz
Added logout redirect to home
94a74ab
@JustinBanzon
Update the navbar in _base.html
0a7cf0c 
Added a dropdown menu for Search, and removed a redundant "Upload" link
@matthewglanz
Added newline for Lint check
400ed5c
@RuikangRPI
alert upload
ad58059 
- alert
- search-result if no result render stuff
@noahcussatti
fix: Navbar "Search" dropdown works correctly
85fd00d
@noahcussatti noahcussatti added enhancement New feature or request Web Dev labels Oct 20, 2023
@noahcussatti noahcussatti requested a review from jaw12346 October 20, 2023 20:45
@jaw12346
Copy link
Member

jaw12346 commented Oct 22, 2023 •
edited
Loading

Landing page in this PR is looking a little funky compared to Production. Please take a look at let me know if this is intentional. Icon not locked to the edge of the screen, "Simplify studying with ACMAS" on the edge rather than floating.
image

@jaw12346
Copy link
Member

jaw12346 commented Oct 22, 2023 •
edited
Loading

"New Search" button after a failed search-by-course and search-by-question is inaccessible when the animated wave goes over it. Please fix by having the button on top of the wave. Button is also broken.
image
image

@jaw12346
Copy link
Member

jaw12346 commented Oct 22, 2023 •
edited
Loading

Please make this into a blue button similar to our other buttons on the site. Same with the registration button below it.
image

@jaw12346
Copy link
Member

Please make this a blue button
image

@jaw12346
Copy link
Member

Search by course is broken. Replicate by using school 'a', course 'b', and attempt to upload a PDF.

@jaw12346
Copy link
Member

Manual upload blue button is inaccessible due to animated wave and does not respond to clicks.
image

@jaw12346
Copy link
Member

Text file reader page buttons inaccessible due to animated wave and do not respond to clicks.
image

@jaw12346
Copy link
Member

Question search results blue button inaccessible due to animated wave.
image

@jaw12346
Copy link
Member

Please make blue Register button.
image

jaw12346
jaw12346 requested changes Oct 22, 2023
View reviewed changes
Copy link
Member

@jaw12346 jaw12346 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve each of my comments and acknowledge once each has been completed by applying a thumbs-up emoji.

jaw12346
jaw12346 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@jaw12346 jaw12346 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, guys! Approved.

@jaw12346 jaw12346 merged commit 7f1c151 into main Oct 24, 2023
3 checks passed
@jaw12346 jaw12346 mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaw12346 jaw12346 jaw12346 approved these changes

Assignees

@noahcussatti noahcussatti

@matthewglanz matthewglanz

@RuikangRPI RuikangRPI

Labels
enhancement New feature or request Web Dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@noahcussatti @jaw12346 @matthewglanz @RuikangRPI @JustinBanzon