Use schemas in Postgres #1866
Merged
Use schemas in Postgres #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1866 +/- ##
==========================================
- Coverage 88.94% 86.99% -1.95%
==========================================
Files 150 156 +6
Lines 11239 11715 +476
Branches 447 458 +11
==========================================
+ Hits 9997 10192 +195
- Misses 1242 1523 +281
|
t-bast
reviewed
Jul 7, 2021
eclair-core/src/test/scala/fr/acinq/eclair/db/AuditDbSpec.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/db/AuditDbSpec.scala
Outdated
Show resolved
Hide resolved
|
Rebased on parent PR and squashed. |
Instead of having a flat hierarchy under the default `public` schema. There is roughly a schema per database type. The new hierarchy is: - `local` - `channels` - `htlc_infos` - `pending_settlement_commands` - `peers` - `network` - `nodes` - `public_channels` - `pruned_channels` - `payments` - `received` - `sent` - `audit` - <all the audit db tables> - `public` - `lease` - `versions` Note in particular, the change in naming for local channels vs external channels: - `local_channels` -> `local.channels` - `channels` -> `network.public_channels` The two internal tables `lease` and `versions` stay in the `public` schema, because we have no meta way of migrating them.
|
Parent PR merged, rebased on master. |
t-bast
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having a flat organization under the default
publicschema, we classify tables in schemas. There is roughly one schema per database type.The new hierarchy is:
localchannelshtlc_infospending_settlement_commandspeersnetworknodespublic_channelspruned_channelspaymentsreceivedsentauditpublicleaseversionsNote in particular, the change in naming for local channels vs external channels:
local_channels->local.channelschannels->network.public_channelsThe two internal tables
leaseandversionsstay in thepublicschema, because we have no meta way of migrating them.