Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a serializer for DoSync #1708

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Add a serializer for DoSync #1708

merged 1 commit into from
Feb 26, 2021

Conversation

pm47
Copy link
Member

@pm47 pm47 commented Feb 26, 2021

This command is sent by the Peer to its PeerConnection, therefore it
needs to be a RemoteType and have its own codec.

This command is sent by the `Peer` to its `PeerConnection`, therefore it
needs to be a `RemoteType` and have its own codec.
@pm47 pm47 requested a review from t-bast February 26, 2021 10:43
@codecov-io
Copy link

Codecov Report

Merging #1708 (0bc440c) into master (5d662fc) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1708      +/-   ##
==========================================
+ Coverage   86.27%   86.30%   +0.02%     
==========================================
  Files         151      151              
  Lines       11699    11701       +2     
  Branches      506      501       -5     
==========================================
+ Hits        10093    10098       +5     
+ Misses       1606     1603       -3     
Impacted Files Coverage Δ
...main/scala/fr/acinq/eclair/io/PeerConnection.scala 83.40% <ø> (+0.42%) ⬆️
...cinq/eclair/remote/EclairInternalsSerializer.scala 97.50% <100.00%> (+0.06%) ⬆️
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala 93.70% <0.00%> (-1.58%) ⬇️
...main/scala/fr/acinq/eclair/router/Validation.scala 92.30% <0.00%> (+1.53%) ⬆️

@pm47 pm47 merged commit 8065d0b into master Feb 26, 2021
@pm47 pm47 deleted the serializer-dosync branch February 26, 2021 11:09
tompro pushed a commit to tompro/eclair that referenced this pull request Mar 7, 2021
This command is sent by the `Peer` to its `PeerConnection`, therefore it
needs to be a `RemoteType` and have its own codec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants