Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Bazel 8 #73

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

neilconway
Copy link

Recent versions of abseil strongly encourage using
Bazel modules. Therefore, switch some dependencies
over to using modules as well, but leave a few
using the old WORKSPACE syntax for now. To enable
this, we rename WORKSPACE to WORKSPACE.bzlmod
(Bazel calls this "hybrid mode").

This also involves upgrading the versions of
several of our dependencies, notably protobuf and
abseil. It would be nice to defer doing this for
now, but some initial investigation suggested that
this would be quite difficult due to the web of
dependencies.

Recent versions of abseil strongly encourage using
Bazel modules. Therefore, switch some dependencies
over to using modules as well, but leave a few
using the old WORKSPACE syntax for now. To enable
this, we rename WORKSPACE to WORKSPACE.bzlmod
(Bazel calls this "hybrid mode").

This also involves upgrading the versions of
several of our dependencies, notably protobuf and
abseil. It would be nice to defer doing this for
now, but some initial investigation suggested that
this would be quite difficult due to the web of
dependencies.
@neilconway neilconway marked this pull request as ready for review December 22, 2024 15:39
`std::filesystem::path` is only available on macOS >= 10.15.
Not every Boost library we need is available on BCR yet (e.g., ICL),
but this seems to be good enough for now.
There seems to be some debate about whether to add these files to git
or ignore them (e.g., [1]). For now, let's ignore them.

[1] bazel-contrib/rules_cuda#223
This appears to be necessary to workaround a bug or odd behavior in
recent versions of Bazel: in eventuals, submodules/stout was considered
to be part of the eventuals repo (despite being declared as a
local_repository) because of the renaming of WORKSPACE.bazel to
WORKSPACE.bzlmod. For the time being, re-add an empty WORKSPACE file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant