-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Bazel 8 #73
Open
neilconway
wants to merge
13
commits into
3rdparty:main
Choose a base branch
from
neilconway:bazel-8-upgrade
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent versions of abseil strongly encourage using Bazel modules. Therefore, switch some dependencies over to using modules as well, but leave a few using the old WORKSPACE syntax for now. To enable this, we rename WORKSPACE to WORKSPACE.bzlmod (Bazel calls this "hybrid mode"). This also involves upgrading the versions of several of our dependencies, notably protobuf and abseil. It would be nice to defer doing this for now, but some initial investigation suggested that this would be quite difficult due to the web of dependencies.
`std::filesystem::path` is only available on macOS >= 10.15.
Not every Boost library we need is available on BCR yet (e.g., ICL), but this seems to be good enough for now.
This reverts commit 13b244b.
There seems to be some debate about whether to add these files to git or ignore them (e.g., [1]). For now, let's ignore them. [1] bazel-contrib/rules_cuda#223
This appears to be necessary to workaround a bug or odd behavior in recent versions of Bazel: in eventuals, submodules/stout was considered to be part of the eventuals repo (despite being declared as a local_repository) because of the renaming of WORKSPACE.bazel to WORKSPACE.bzlmod. For the time being, re-add an empty WORKSPACE file.
This reverts commit 271adb8.
This reverts commit 62d20b2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of abseil strongly encourage using
Bazel modules. Therefore, switch some dependencies
over to using modules as well, but leave a few
using the old WORKSPACE syntax for now. To enable
this, we rename WORKSPACE to WORKSPACE.bzlmod
(Bazel calls this "hybrid mode").
This also involves upgrading the versions of
several of our dependencies, notably protobuf and
abseil. It would be nice to defer doing this for
now, but some initial investigation suggested that
this would be quite difficult due to the web of
dependencies.