Allow excluding regions #6278
Merged
Allow excluding regions #6278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ApCoder123
added
the
enhancement
|
I like the idea! What if instead of a new array we used "regions" : [
"-us"
]That would make it look neater if/when we add region groups like europe and north america. |
Fix region code validation Fix map statement Fix rubocop errors
ApCoder123
force-pushed
the
exclude-regions
branch
from
2a2c0a4 to
85016d0
Compare
Carlgo11
approved these changes
Nov 15, 2021
phallobst
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a site is available everywhere in the world apart from one region, it is necessary to list all region codes in the
regionsarray apart from that region to exclude it from that single region's site. This PR modifies theregionsarray to allow excluding regions to prevent sites that aren't available in certain regions from being displayed on their regional sites.Examples of entries would be: