Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contribution guide clarifications #6152

Merged
merged 4 commits into from
Oct 1, 2021
Merged

Contribution guide clarifications #6152

merged 4 commits into from
Oct 1, 2021

Conversation

ApCoder123
Copy link
Member

  • Fixed some typos
  • Removed outdated "Running Locally" section and linked to relevant section in README
  • Clarified excluded sites
  • Removed url field from example and further clarified below (I've noticed this field being added unnecessarily quite a lot)
  • Added note that keywords should be a valid category name

@ApCoder123 ApCoder123 added the enhancement Issue/PR contains enhancements to the overall code of the site. label Oct 1, 2021
phallobst
phallobst requested changes Oct 1, 2021
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@phallobst phallobst merged commit 6688471 into 2factorauth:master Oct 1, 2021
@ApCoder123 ApCoder123 deleted the contributing branch October 1, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carlgo11 Carlgo11 Carlgo11 approved these changes

@phallobst phallobst phallobst approved these changes

Assignees
No one assigned
Labels
enhancement Issue/PR contains enhancements to the overall code of the site.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ApCoder123 @phallobst @Carlgo11