Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dropbox #6139

Merged
merged 4 commits into from
Oct 2, 2021
Merged

Update Dropbox #6139

merged 4 commits into from
Oct 2, 2021

Conversation

ApCoder123
Copy link
Member

No description provided.

@ApCoder123 ApCoder123 added the update site Issue/PR updates information about a site in the repo. label Sep 26, 2021
@ApCoder123
Copy link
Member Author

Looks like the URL validation test is failing, because dropbox is returning a 409 error due to an outdated user agent

From the response body:
<h1>Upgrade your browser to use Dropbox</h1> <div> <p>Your current browser is not supported. We support the latest versions of the following browsers:</p> .

@Carlgo11, Would it maybe be better to only fail for specific status codes (e.g. 404) and warn for anything else?

@Carlgo11
Copy link
Member

Carlgo11 commented Sep 26, 2021

@ApCoder123 it seems to be because of the user-agent. I don't really understand their reasoning for completely blocking old versions instead of trying to serve the content and let the client interpret as much as it can. Anyways, anything containing (compatible; MSIE xx.xx) gets blocked by Dropbox.

I specified a user-agent because sierra.com would 200 user-agents that are known to not support JS but since 503 responses are now just a soft fail I guess the user-agent can be changed or removed.
Either to a modern user-agent or to something signalling that it is our bot.

@ApCoder123 ApCoder123 reopened this Oct 2, 2021
@Carlgo11 Carlgo11 merged commit 072bc80 into 2factorauth:master Oct 2, 2021
@ApCoder123 ApCoder123 deleted the dropbox branch October 2, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update site Issue/PR updates information about a site in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants