Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DBS Bank Singapore #3599

Merged
merged 4 commits into from
Jan 11, 2019
Merged

Add DBS Bank Singapore #3599

merged 4 commits into from
Jan 11, 2019

Conversation

ChristopherZhong
Copy link
Contributor

Signed-off-by: Christopher Zhong 1946052+ChristopherZhong@users.noreply.github.com

Signed-off-by: Christopher Zhong <1946052+ChristopherZhong@users.noreply.github.com>
@brycx
Copy link
Contributor

brycx commented Dec 26, 2018

Are there docs available which are a bit more descriptive? This one just has a list of things that you can use and for what purposes. If more descriptive docs are available but only for registered users, please take a screenshot and post it here. Remember to blur out any personal information. Thanks.

@ChristopherZhong
Copy link
Contributor Author

Are there docs available which are a bit more descriptive? This one just has a list of things that you can use and for what purposes. If more descriptive docs are available but only for registered users, please take a screenshot and post it here. Remember to blur out any personal information. Thanks.

Is this link more appropriate?

@Carlgo11 Carlgo11 added the add site Issue/PR adds a site to the repo. label Dec 27, 2018
@Carlgo11 Carlgo11 requested a review from brycx January 9, 2019 00:28
@mxxcon
Copy link
Contributor

mxxcon commented Jan 9, 2019

Hmm....
Actually reading the current and your original url (https://www.dbs.com.sg/ibanking/help/2fa-login.html) a bit closer, unless I'm misunderstanding something, it seems like according to our definition this site would be tfa: no.
They only ask for username and password to login(authenticate). Other methods come into play only when you perform specific operations(authorization).
Correct me if I'm wrong in this aspect..

@ChristopherZhong
Copy link
Contributor Author

Hmm....
Actually reading the current and your original url (https://www.dbs.com.sg/ibanking/help/2fa-login.html) a bit closer, unless I'm misunderstanding something, it seems like according to our definition this site would be tfa: no.
They only ask for username and password to login(authenticate). Other methods come into play only when you perform specific operations(authorization).
Correct me if I'm wrong in this aspect..

Yes. Upon further exploration, it appears that tfa: no. I will update it

@mxxcon mxxcon merged commit e9823a4 into 2factorauth:master Jan 11, 2019
@ChristopherZhong ChristopherZhong deleted the add-DBS-Bank-Singapore branch January 12, 2019 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add site Issue/PR adds a site to the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants