Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sophos Central #3483

Merged
merged 6 commits into from
Oct 8, 2018
Merged

Add Sophos Central #3483

merged 6 commits into from
Oct 8, 2018

Conversation

arnydo
Copy link

@arnydo arnydo commented Oct 1, 2018

No description provided.

stephengroat
stephengroat previously approved these changes Oct 1, 2018
Copy link
Contributor

@stephengroat stephengroat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arnydo thanks for the pr!

@stephengroat stephengroat added the add site Issue/PR adds a site to the repo. label Oct 1, 2018
@@ -237,6 +237,14 @@ websites:
twitter: SaferVPN
facebook: SaferVPNCom

- name: Sophos Central
url: https://central.sophos.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main url seems to be https://www.sophos.com. Please change the value of the url tag to that.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can certainly change to the requested URL, however, they have several products and not all support MFA... Sophos Central is one that Does support MFA.

- name: Sophos Central
url: https://www.sophos.com
img: sophoscentral.png
tfa: yes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please capitalize all Yes values

Copy link
Author

@arnydo arnydo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the "yes" values. Capitalized each.

@Carlgo11
Copy link
Member

Carlgo11 commented Oct 6, 2018

For the email part of the authentication, is that instead of a password?

@arnydo
Copy link
Author

arnydo commented Oct 8, 2018

For the email part of the authentication, is that instead of a password?

No, it is in addition to the password. The email contains a OTP (4 digit code) as an alternative to Google Authenticator.

@Carlgo11 Carlgo11 merged commit 2e64f4e into 2factorauth:master Oct 8, 2018
@carlylemiii
Copy link

This should have included "Exceptions" like done for Wikipedia and OpenDNS, for example, and been named just Sophos if the URL wasn't going to be specific to Sophos Central. 🙁

@Carlgo11
Copy link
Member

Carlgo11 commented Nov 8, 2018

I’m not sure I understand what you mean @carlylemiii.
The listing is for Sophos Centeal and not any other products.

Our guidlines require the url tag to link to the service’s main page. It also can’t be linked to a login page or similar.

The name should make it obvious that it’s only for Sophos Central and not any other product.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add site Issue/PR adds a site to the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants