Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eBay Kleinanzeigen (DE) #3390

Merged
merged 3 commits into from
Apr 27, 2019
Merged

Add eBay Kleinanzeigen (DE) #3390

merged 3 commits into from
Apr 27, 2019

Conversation

melgu
Copy link
Contributor

@melgu melgu commented Aug 22, 2018

No description provided.

@mxxcon
Copy link
Contributor

mxxcon commented Aug 22, 2018

Can you use your existing ebay login with this site?

@melgu
Copy link
Contributor Author

melgu commented Aug 22, 2018

@mxxcon No, it's separate.

@jamcat22 jamcat22 added the add site Issue/PR adds a site to the repo. label Aug 24, 2018
@kmpoppe
Copy link
Member

kmpoppe commented Jan 29, 2019

Global Alexa rank is 236 (8 in Germany) today. ebay-KA and ebay still use different logins.

@Carlgo11
Copy link
Member

@kmpoppe is ebay Kleinanzeigen just a German fork of ebay or is it a completely different thing?

@kmpoppe
Copy link
Member

kmpoppe commented Jan 29, 2019

@Carlgo11
eBay Kleinanzeigen (small ads/classified ads/want ads) is a completely different site from eBay, it has a different concept (no fees, direct contact between buyer and seller). Yet, it is eBay because both eBay GmbH (ebay.de) and eBay Kleinanzeigen GmbH (ebay-kleinanzeigen.de) both have their registered business addresses at the same point.

@Carlgo11
Copy link
Member

@kmpoppe so it's like craigslist? I'm just trying to understand what category it fits the best in.

@melgu
Copy link
Contributor Author

melgu commented Jan 30, 2019

Yes, pretty much.

@kmpoppe
Copy link
Member

kmpoppe commented Jan 30, 2019

@Carlgo11 as @melgu said, yes, craigslist is a pretty good comparison.

kmpoppe
kmpoppe requested changes Feb 1, 2019
View reviewed changes
Copy link
Member

@kmpoppe kmpoppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@melgu Could you reduce the file-size of the logo? You can use OptiPNG (as described in the CONTRIBUTING.md of the project). Maintainers of the project like fast-loading images ;-)

@kmpoppe
Copy link
Member

kmpoppe commented Feb 5, 2019

Bump @Carlgo11

kmpoppe
kmpoppe previously approved these changes Apr 11, 2019
View reviewed changes
@melgu
Copy link
Contributor Author

melgu commented Apr 24, 2019

Could someone please approve the pull request?
Isn't this repo active anymore?

@kmpoppe kmpoppe requested a review from Carlgo11 April 24, 2019 20:17
@kmpoppe
Copy link
Member

kmpoppe commented Apr 24, 2019

Thank you for your contribution, @melgu!
This repo is active, yet all Members are volunteers doing everything in their spare time.
I have requested @Carlgo11 to review this PR as he's currently one of the most active ones.
Please be patient.

@melgu
Copy link
Contributor Author

melgu commented Apr 24, 2019

Thanks for your work!
I hope, I didn't come off as rude, because I didn't mean to.

Carlgo11
Carlgo11 requested changes Apr 25, 2019
View reviewed changes
Copy link
Member

@Carlgo11 Carlgo11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think their favicon looks better than the logo you supplied:
logo

@kmpoppe kmpoppe merged commit 3b24f61 into 2factorauth:master Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmpoppe kmpoppe kmpoppe approved these changes

@Carlgo11 Carlgo11 Carlgo11 approved these changes

Assignees
No one assigned
Labels
add site Issue/PR adds a site to the repo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@melgu @mxxcon @kmpoppe @Carlgo11 @jamcat22