Search by url and website name #3123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpigerre
added
the
enhancement
fpigerre
approved these changes
Apr 11, 2018
|
@PSGS all done? You can merge if you think it's fine. |
|
I get an error when running the site: |
|
Run bundle update, Jekyll 3.3.1 is old. GitHub pages is on 3.7.3 and should
not have such error in building
…On Tue, Jun 19, 2018 at 7:13 AM Carlgo11 ***@***.***> wrote:
I get an error when running the site:
jekyll 3.3.1 | Error: Liquid syntax error (line 1): Tag '{%- assign
website = include.website -%}' was not properly terminated with regexp:
/\%\}/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3123 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKeM11PPX3wZNMI3UQXYSBjQ0GPAWkYzks5t-NzkgaJpZM4TNgAe>
.
|
|
That worked. |
|
Yea, the hyphens must be new but it’s rooted in the liquid syntax
standards. Basically defines that ignore white space after this until the
next element. So it can be very useful to ensuring the compiled size is
exactly as you meant it to be
…On Tue, Jun 19, 2018 at 7:38 AM Carlgo11 ***@***.***> wrote:
That worked.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3123 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKeM18CCZI8zbSE6ePiLizGE3Sq3Nw46ks5t-OKsgaJpZM4TNgAe>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3118 by introducing a new way of defining the search keywords. In this approach, we get the benefit of whatever text we put into the field and since we use this for both mobile and desktop tables, its automatically added to each of them consistently.
No defaults needed for this as we are using two required fields.