Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Synchrony Bank #3105

Merged
merged 13 commits into from
May 14, 2018
Merged

Add Synchrony Bank #3105

merged 13 commits into from
May 14, 2018

Conversation

Sunit-Kulkarni
Copy link
Contributor

This is the largest issuing bank of credit cards in the united states.

@fpigerre fpigerre added the add site Issue/PR adds a site to the repo. label Apr 5, 2018
conorgil
conorgil approved these changes Apr 21, 2018
View reviewed changes
Copy link
Contributor

@conorgil conorgil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran this locally and seems fine to me.

  • Doc link works
  • Image looks good
  • all HTTPS links

Carlgo11
Carlgo11 requested changes May 11, 2018
View reviewed changes
Copy link
Member

@Carlgo11 Carlgo11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc link you provided states that voice calls are provided as well. Please add phone: Yes 😄

@Carlgo11 Carlgo11 changed the title Synchrony Bank Add Synchrony Bank May 11, 2018
@Sunit-Kulkarni
Copy link
Contributor Author

Good catch. Just added it!

Carlgo11
Carlgo11 approved these changes May 13, 2018
View reviewed changes
Copy link
Member

@Carlgo11 Carlgo11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@mxxcon mxxcon merged commit d0ccfa0 into 2factorauth:master May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carlgo11 Carlgo11 Carlgo11 approved these changes

@conorgil conorgil conorgil approved these changes

@mxxcon mxxcon mxxcon approved these changes

Assignees
No one assigned
Labels
add site Issue/PR adds a site to the repo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sunit-Kulkarni @mxxcon @conorgil @Carlgo11 @fpigerre