Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to jquery.lazy for image loading #3090

Merged
merged 2 commits into from
Apr 5, 2018

Conversation

stephengroat
Copy link
Contributor

maintained project

fixes current slow load time issues

@stephengroat stephengroat added the enhancement Issue/PR contains enhancements to the overall code of the site. label Mar 28, 2018
js/app.js Outdated
@@ -6,7 +6,7 @@ $(document).ready(function () {
}

// Unveil images 50px before they appear
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this code comment need to be updated? Does jquery.lazy still use 50px as the padding for lazy loading?

@fpigerre
Copy link
Contributor

fpigerre commented Apr 5, 2018

I'm fast-tracking this pull request with one review as a result of discussion in #2893, so that we can merge #3015.

@fpigerre
Copy link
Contributor

fpigerre commented Apr 5, 2018

Plugin being used can be found at http://jquery.eisbehr.de/lazy/.

@fpigerre fpigerre changed the title move to jquery.lazy for image loading Move to jquery.lazy for image loading Apr 5, 2018
@fpigerre fpigerre merged commit 08a2d54 into 2factorauth:master Apr 5, 2018
@stephengroat stephengroat deleted the jquery-lazy branch April 5, 2018 04:26
@mxxcon mxxcon mentioned this pull request Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR contains enhancements to the overall code of the site.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants