Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bitflyer and Bithumb #2848

Merged

Conversation

spazvt
Copy link
Contributor

@spazvt spazvt commented Nov 13, 2017

add 'Bitflyer' and 'Bithumb' crypto currency exchanges from fork
https://github.com/acceptbitcoincash/acceptbitcoincash

Bithumb is a major South Korean exchange right now.

* add 'Bitflyer' and 'Bithumb' crypto currency exchanges from fork
  https://github.com/acceptbitcoincash/acceptbitcoincash
@spazvt spazvt force-pushed the addBitflyerAndBithumbCryptoExchange branch from f58fbd5 to 0e28499 Compare November 13, 2017 04:52
@jamcat22 jamcat22 added the add site Issue/PR adds a site to the repo. label Nov 30, 2017
@Carlgo11 Carlgo11 changed the title add Bitflyer and Bithumb from 'acceptbitcoincash' Add Bitflyer and Bithumb Dec 5, 2017
@spazvt
Copy link
Contributor Author

spazvt commented May 13, 2018

These two websites have A LOT of traffic.
Bithumb Alexa rank is 4930 globally and 153 in South Korea.
Bitflyer Alexa rank is 2932 globally and 236 in Japan.

Please use google translate to verify the Google Authenticator and OTP instructions for bithumb. (I don't know Korean, but it links directly to their user page to show users how to enable it.)

_data/cryptocurrencies.yml Outdated Show resolved Hide resolved
@spazvt
Copy link
Contributor Author

spazvt commented May 24, 2018

URL updated to https and verified that all of my other open PRs include only https links.

Copy link
Member

@Carlgo11 Carlgo11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bitflyer logo you provided contains text which often makes the logo look weird when shrunken down to 32x32 pixels. Here's one from their site that just is the logo (without any text).
32x32

@spazvt
Copy link
Contributor Author

spazvt commented May 24, 2018

ok I'll avoid text next time.

@brycx brycx merged commit 726ea0e into 2factorauth:master Jun 5, 2018
@spazvt spazvt deleted the addBitflyerAndBithumbCryptoExchange branch June 6, 2018 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add site Issue/PR adds a site to the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants