So what's the advantage of this over what we already have?

@mxxcon it's just a cleanup. No advantages more than that the code looks nicer

On Sep 17, 2016, at 00:09, mxxcon notifications@github.com wrote:

So what's the advantage of this over what we already have?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

But we now have a new dependency on rubocop gem, don't we?

adds a gem dependency only for test. my goal is to add a lot more to the test

1. figure out more extensive tests to run just on sections updated by a git pull (url checking etc)
2. get an internal section that uses apis (twitter, facebook, domaintally). since the only PRs that are made by members can use API keys, maybe start creating an internal PR from master to gh-pages to trigger travis to do those

i think it would be a a great goal to automate ourselves out of existence

psst, rebase when you're done 😉

will do. geez, it's like the guy trying to commit stuff for code cleanliness should have clean commits. seems like a lot of work ...

I agree it's dependency/another way for the build to fail, but I'm not sure I agree with:

My view on the build statuses is that checks should be run for things essentials for the project but not for cosmetic purposes only.

Why not check whatever pieces can be automatically checked? I would think that the eventual goal of this project would be that every piece of a PR is checked during the CI process and only minimal human review is needed (i.e. i saw that previous URL checking produced timeouts during the build process, but what if only the URLs affected by the PR were checked (reducing the URL checking surface area)).

P.S. i don't mean to be an ass

With cosmetic purposes I mean things like formatting and white space. URL checking is not something cosmetic.

Making the code look nice is a good thing but the build shouldn't fail just because of formatting.

(Accidentally closed the PR. Opened it again 😅)

I we don't allow PRs if they remove trailing whitespace, shouldn't that be part of the automated checks?