Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connector: Liquidity metrics #116

Merged
merged 3 commits into from
May 21, 2021
Merged

Connector: Liquidity metrics #116

merged 3 commits into from
May 21, 2021

Conversation

PJColombo
Copy link
Member

@PJColombo PJColombo commented May 20, 2021 •
edited
Loading

This PR solves issue #111 by adding support to fetch gardens by an entity field, e.g., their honey liquidity.

0xGabi
0xGabi approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@0xGabi 0xGabi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 🔥

Using the example for running a test was smooth.

@0xGabi 0xGabi merged commit 2f72e18 into 1Hive:master May 21, 2021
@PJColombo PJColombo deleted the connector-liquidity-metrics branch May 21, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xGabi 0xGabi 0xGabi approved these changes

@fabriziovigevani fabriziovigevani Awaiting requested review from fabriziovigevani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PJColombo @0xGabi