Iterate on css/sass architecture, design implement progress #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| font-style: normal; | ||
| font-weight: 700; | ||
| src: font-url("merriweather-bold-webfont.eot?#iefix") format("embedded-opentype"), font-url("merriweather-bold-webfont.woff2") format("woff2"), font-url("merriweather-bold-webfont.woff") format("woff"), font-url("merriweather-bold-webfont.ttf") format("truetype"); | ||
| } |
There was a problem hiding this comment.
Just a minor style issue that Code Climate would have flagged if the webhook was working: Please convert the double quotes to single quotes.
|
Other than the style issues, this looks good to me. |
|
thanks for getting codeclimate back up, and pointing me to command line tool! |
|
No problem. Looks much better now. If you can please add the newline to the end of |
**Why**: Some engines that we care about were turned off, and Code Climate was not properly ignoring certain files that we want to exclude from analysis. **How**: Remove the `exclude_paths` directive from the Code Climate config, and use the individual linter configs to exclude files.
brendansudol
force-pushed
the
add-styles
branch
from
c3d9e6d to
ce8901d
Compare
|
Not sure why Code Climate is complaining about files that aren't part of this PR. I wonder it has to do with the merge from master, then rebase that we did. In any case, I'm merging this in since you fixed the linting issue specific to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the basscss sass files (removes unnecessary variables that get created during the build process here, uses v7.1), and continues work to implement designs for login/signup pages