Move condition check above potential database queries #11706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: Internal, Performance, Move condition check above potential database queries
Sgtpluck
approved these changes
Jan 6, 2025
aduth
approved these changes
Jan 6, 2025
app/controllers/two_factor_authentication/otp_verification_controller.rb
Outdated
Show resolved
Hide resolved
matthinz
pushed a commit
that referenced
this pull request
Jan 7, 2025
* Move condition check above potential database queries changelog: Internal, Performance, Move condition check above potential database queries * rename confirmation analytics method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
I was looking in NewRelic and saw a transaction that included multiple and potentially unnecessary identical database queries for
BackupCodeConfiguration. The culprit appears to be an analytics method that queries for MFA information so it can be logged. The logging was conditional, so we can at least eliminate the query in cases where the conditional is false by bringing the conditional check up and avoiding the method call entirely.