-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy RC 437 to Production #11614
Merged
Merged
Deploy RC 437 to Production #11614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of how this spec tests initializers, it can leave weirdly configured AB tests around after it runs. This is usually not a problem, but can introduce flakiness in CI. [skip changelog]
…ging (#11601) changelog: Internal, Anti-Fraud, Omit policy_details_api from ThreatMetrix response body logging
…ders (#11591) We have been working through issues with a service provider who has observed that users do not return to their SP after entering their mailed code or passing fraud review. We identified an opportunity to provide users with a direct link back to the SP to re-initiate their session when they complete out-of-band proofing. This commit adds a `post_idv_followup_url` to the SP configuration for this purpose. This URL is used in the `account_verified` email if it is present. In future changes we plan to add a CTA after the user enters a mailed code and to the account page if the user has not connected their account. This change should not impact SPs that do not have a `post_idv_followup_url` configured. [skip changelog]
* Fall back to after_mfa_setup_path for nil next_setup_path changelog: Bug Fixes, Face/Touch Recommendation, Fix edge case for duplicate submission in recommendation * Use SubmitButtonComponent for Face/Touch recommendation
Return a Profile from Idv::Session::create_profile_from_applicant_with_password, then use that directly in EnterPasswordController. [skip changelog]
* Update erb_lint to 0.7.0 0.5.0 was spitting out warnings related to rubocop deprecations [skip changelog] * Rename .erb-lint.yml to silence warning * We say erb_lint now erb_lint complains if you invoke it with `erblint`. This silences that warning. * Fix a couple more instances of erb-lint
changelog: Internal, In-person Proofing, Cancel in-person enrollments when profiles are deactivated due to encryption error.
changelog: Internal, RSpec Matchers, Adds match_xml matcher and cleans up gross fixture
… better error for a testing scenario (#11609)
* rebase - merge conflicts resolved * [skip changelog] * rebase - merge conflicts resolved * defualt docv_transaction_token_override to nil in doc reesult request * test docvTransaction override * add docv token override tests to hybrid flow * rebase - merge conflicts resolved * undo the destroy of all users and email addresses * rebase - merge conflicts resolved * rebase - merge conflicts resolved * rebase - merge conflicts resolved * remove public/browserconfig.xml * add needed end empty line * fix signature post rebase * happy linting * add test when user does/not complete docv * refactor to use guards * combine specs for invalid doc token during docv test mode * refacgtor mobile socure test to watit for docv token
* changelog: Internal, Analytics, Update signature query to use more accurate event
…ing (#11592) * add new mobile no selfie text for how to verify * add mobile_required to how to verify * rename _selfie to _mobile for better clarity in how_to_verify_presenter when needed * add changelog changelog: User-Facing Improvements, Doc Auth, Update text on how to verify page for mobile non selfie flow * remove desktop_selfie_test_mode from presenter check
… code (#11602) In #11591 we added a `post_idv_follow_up_url` that allows users to return to a service provider after finishing verification out-of-band. This commit puts this new URL to work in the verify-by-mail code. After this commit users who enter a verify-by-mail code without an SP in their session will see a new SP follow-up screen. This screen includes a CTA that prompts the user to connect their account to the service provider they started proofing with. This link leads to the new post-IdV follow-up URL. changelog: User-Facing Improvements, Verify-by-mail, A CTA was added to prompt users to return to the service provider after verify-by-mail
* started work on ticket defined methods * changelog: Upcoming Features, socure, socure analytics * changelog: Upcoming Features, socure, socure analytics logging * Resolving PR comments * Resolving PR comments * Resolving PR comments * resolving some comments still needs works * Fixing lint, resolving PR comments, might fail hybrid test * Fixing hybrid test * Resolving PR comments for hybrid flow * Fixing Rebase
eileen-nava
requested review from
matthinz,
aduth,
jmhooper,
shanechesnutt-ft,
n1zyy,
Sgtpluck,
amirbey,
theabrad and
AShukla-GSA
December 10, 2024 15:47
aduth
approved these changes
Dec 10, 2024
matthinz
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features