Initial set of acceptance tests, using WP Acceptance #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 7, 2019 11:21
… the log out function more reliable.
…not enforced. Fix a typo. Add additional testing for external URL redirects.
|
Note: looks like there are some issues right now with getting these tests to run in the pipeline. Not exactly sure how to set this up properly but will take a closer look when I can. |
…s in the core framework.
| $contains = true; | ||
| } | ||
|
|
||
| $this->assertTrue( $contains ); |
There was a problem hiding this comment.
can we do this and skip creating $contains?
Suggested change
| $this->assertTrue( $contains ); | |
| $this->assertTrue( false !== strpos( $I->getCurrentUrl(), 'wp-login.php' ) ); |
|
|
||
| usleep( 500 ); | ||
|
|
||
| $contains = false; |
There was a problem hiding this comment.
same comment as below about $contains, maybe just simplify into assertion?
|
@dkotter This is great! I'm still working to get tests passing locally and in Travis, I will update with progress here. |
|
After clearing docker I was able to get all test passing locally. I ran them with
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adding in the initial set of acceptance tests, utilizing the WP Acceptance framework. Currently have tests for the following situations:
Benefits
These tests can be run on any PR, ensuring that all functionality works as expected. This makes releases more stable.
Possible Drawbacks
These tests will be run as part of the PR pipeline, resulting in more time spent to finish that pipeline.
Checklist:
Applicable Issues
#55 #83