Fix 'Redirect to same path' setting screen-reader-text #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffpaul
requested review from
a team and
dkotter
and removed request for
a team
dkotter
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fix missing screen-reader-text on setting 'Redirect to same path' being obtained from a non-existing setting array.
Fixes #167
Alternate Designs
The method to populate the default settings only passes the field values, not the labels.
So, for now, this PR sets the label as all other fields, hardcoded and duplicating the label.
In the future this could be improved to avoid duplication of this label strings.
Benefits
Fix PHP error and setting screen reader text.
Possible Drawbacks
None
Checklist: