Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/160: phpunit Github Actions #161

Merged
merged 4 commits into from
Oct 13, 2021
Merged

test/160: phpunit Github Actions #161

merged 4 commits into from
Oct 13, 2021

Conversation

Sidsector9
Copy link
Member

@Sidsector9 Sidsector9 commented Oct 11, 2021

Closes #160

Setup of PHPUnit on Github Actions.

Note: The failed test is resolved in PR #163

@Sidsector9 Sidsector9 changed the title test: phpunit Github Actions test/160: phpunit Github Actions Oct 11, 2021
@Sidsector9 Sidsector9 requested a review from dinhtungdu October 11, 2021 03:50
@jeffpaul jeffpaul added this to the 7.3.0 milestone Oct 11, 2021
Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sidsector9 thanks for the PR! The workflow looks good. The test is passing too. I notice a minor issue about the PHPUnit configuration, mind take a look and fix that issue in this PR as well?

Error Details
Configuration: /home/runner/work/restricted-site-access/restricted-site-access/phpunit.xml

  Warning - The configuration file did not pass validation!
  The following problems have been detected:

  Line 11:
  - Element 'exclude', attribute 'suffix': The attribute 'suffix' is not allowed.

  Line 12:
  - Element 'exclude', attribute 'suffix': The attribute 'suffix' is not allowed.

  Test results may not be as expected.

@jeffpaul jeffpaul merged commit 1ed3ac0 into develop Oct 13, 2021
@jeffpaul jeffpaul deleted the test/160 branch October 13, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup GitHub Actions for PHPUnit
3 participants