Improve Composer configuration and support. #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds more detail to the `composer.json` configuration file. - Sets the indent style for `composer.json` to tabs (matches other 10up plugins).
dinhtungdu
reviewed
Jun 4, 2020
There was a problem hiding this comment.
Thank @kopepasah for the PR. I suggest some minor modification, otherwise, this looks good.
.editorconfig
Outdated
Comment on lines
13
to
15
| indent_style = tab | ||
| indent_size = 4 |
There was a problem hiding this comment.
For files which is not php/css/js, we should use 2 spaces indent.
There was a problem hiding this comment.
I simply followed what already existed in another 10up plugin.
There was a problem hiding this comment.
What is the plugin you refered to?
There was a problem hiding this comment.
dinhtungdu
previously approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
composer.jsonconfiguration file.composer.jsonto tabs (matches other 10up plugins).Alternate Designs
None.
Benefits
Better information and integration when using plugin with Composer.
Possible Drawbacks
None.
Verification Process
Successfully ran the installer (albeit with the
--ignore-platform-reqsflag).Checklist:
My change requires a change to the documentation.I have updated the documentation accordingly.I have added tests to cover my change.All new and existing tests passed.