Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted ElasticPress 5.0.0 fixes. #3735

Merged
merged 7 commits into from
Oct 30, 2023
Merged

Conversation

JakePT
Copy link
Contributor

@JakePT JakePT commented Oct 30, 2023

Description of the Change

Fixes a number of miscellaneous issues in EP 5.0.0 testing:

  • Reverts the sync icon to the one that spins correctly.
  • Adds a target _blank to an ElasticPress.io link on install screen.
  • Makes checkboxes look more obviously disabled on Features and Sync pages.
  • Stops a JS error appearing when sync requests are intentionally aborted.
  • Makes the Sync page a form, so pressing Enter on a control will start a sync and the browser will validate inputs.
  • Prevents negative numbers when setting an object ID range on the Sync page.
  • Limits the Sync History to 5 items at all times.
  • Fixes a JavaScript error in development mode when a Feature displays multiple requirements status messages.

Changelog Entry

N/A

Credits

Props @JakePT @burhandodhy @MARQAS

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@JakePT JakePT changed the base branch from develop to 5.0.0 October 30, 2023 10:37
@JakePT JakePT requested a review from felipeelia October 30, 2023 10:37
@felipeelia felipeelia merged commit c388a43 into 5.0.0 Oct 30, 2023
9 of 14 checks passed
@felipeelia felipeelia deleted the fix/elasticpress-5-fixes branch October 30, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants