Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated feature settings UI #3712

Merged
merged 31 commits into from
Oct 23, 2023
Merged

Updated feature settings UI #3712

merged 31 commits into from
Oct 23, 2023

Conversation

JakePT
Copy link
Contributor

@JakePT JakePT commented Oct 18, 2023 •
edited
Loading

Description of the Change

Makes the following changes to features classes:

  • Add full feature description to summary property.
  • For features that depend on another feature, use requires_feature property instead of requirements status.
  • Remove ElasticPress.io logo from feature titles, and replace with is_powered_by_epio property.
  • Returns feature visibility in returned data for JSON.

And adds the updated UI.

elasticpress test_wp-admin_admin php_page=elasticpress (1)

How to test the Change

Changelog Entry

Changed - New feature settings screen

Credits

Props @JakePT, @felipeelia, Apurv Ray

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@JakePT JakePT requested a review from felipeelia October 18, 2023 16:28
@JakePT JakePT changed the title Feature class updates Updated feature settings UI Oct 19, 2023
@JakePT JakePT mentioned this pull request Oct 19, 2023
Closed
1 task
@JakePT JakePT self-assigned this Oct 19, 2023
@JakePT JakePT added this to the 5.0.0 milestone Oct 19, 2023
@JakePT
Copy link
Contributor Author

JakePT commented Oct 19, 2023 •
edited
Loading

@felipeelia The last few test errors seem to be are:

  • An error in the Instant Results feature caused by "Category (product_cat)" not being a filter option. This is caused by set_settings_schema() being called before the taxonomy is registered.
  • Documents is sometimes failing for some reason. They are passing for me locally, and I think it might just be because not enough time is taken between syncing and searching the PDF.
  • Comments seems to occasionally failing because there's 26 comments instead of 27 (or vice verse). That doesn't seem to be specific to this PR.

@felipeelia felipeelia merged commit 8a4a379 into 5.0.0 Oct 23, 2023
12 of 13 checks passed
@felipeelia felipeelia deleted the feature/feature-settings-ui branch October 23, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipeelia felipeelia felipeelia left review comments

Assignees

@JakePT JakePT

Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JakePT @felipeelia