Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Number of expected arguments #3690

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Fix: Number of expected arguments #3690

merged 1 commit into from
Oct 6, 2023

Conversation

burhandodhy
Copy link
Contributor

Description of the Change

This PR reduce the expected number of arguments from 3 to 1 as add_attachment and edit_attachment action support one argument that is post_id

Closes #

How to test the Change

Changelog Entry

Fixed - Number of expected arguments for add_attachment and edit_attachment

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 4.7.2 milestone Oct 6, 2023
@felipeelia felipeelia merged commit 0217bee into develop Oct 6, 2023
10 checks passed
@felipeelia felipeelia deleted the fix/number-of-expected-parameter branch October 6, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.7.2
Development

Successfully merging this pull request may close these issues.
2 participants
@burhandodhy @felipeelia