Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/validate settings #3684

Merged
merged 7 commits into from
Oct 18, 2023
Merged

Feature/validate settings #3684

merged 7 commits into from
Oct 18, 2023

Conversation

felipeelia
Copy link
Member

Description of the Change

Closes #3570

How to test the Change

Changelog Entry

Changed - EP Settings are now reverted if it is not possible to connect to the new ES Server.

Credits

Props @felipeelia

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 5.0.0 milestone Oct 5, 2023
@felipeelia felipeelia changed the base branch from develop to 5.0.0 October 5, 2023 17:38
burhandodhy
burhandodhy approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@burhandodhy burhandodhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one nit suggestion, otherwise looks good to me.

includes/classes/Screen/Settings.php Outdated Show resolved Hide resolved
@felipeelia felipeelia merged commit 5b8b5a1 into 5.0.0 Oct 18, 2023
9 checks passed
@felipeelia felipeelia deleted the feature/validate-settings branch October 18, 2023 16:12
@felipeelia felipeelia mentioned this pull request Oct 18, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burhandodhy burhandodhy burhandodhy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

BUG: Site performance drops while plugin is active but not configured
2 participants
@felipeelia @burhandodhy