Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rely on WP site-default option + only display available langs #3587

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Rely on WP site-default option + only display available langs #3587

merged 2 commits into from
Aug 9, 2023

Conversation

felipeelia
Copy link
Member

Description of the Change

Closes #3586

How to test the Change

Changelog Entry

Changed - Only display available languages in the Settings screen

Credits

Props @JakePT and @felipeelia

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 4.7.0 milestone Aug 9, 2023
burhandodhy
burhandodhy approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@burhandodhy burhandodhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felipeelia felipeelia merged commit 4160ba9 into develop Aug 9, 2023
@felipeelia felipeelia deleted the feature/issue-3586 branch August 9, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burhandodhy burhandodhy burhandodhy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

Language Selector
2 participants
@felipeelia @burhandodhy