Add isFirstSearch prop to Instant Results #3568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarssanchez
changed the title
JakePT
requested changes
Aug 3, 2023
JakePT
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR adds a new
isFirstSearchto keep track of whether we are on the first time searching in instant results. If it is set to true instant results will show a "Loading results" text until we have set the results from Elastic.Closes #3508
How to test the Change
1.- With instant results activated, search for a term
2.- You should see the text "Loading results" instead of "0 results" for a brief moment
Changelog Entry
Credits
Props @oscarssanchez, @JakePT, @felipeelia
Checklist: