Fix PHP 8.2 deprecation notice in WooCommerce\Orders. #3507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a deprecation notice because the `index` property is undeclared and created dynamically.
mwidmann
changed the title
|
Thanks @mwidmann. Do you mind making it protected instead of private? Then we can have that merged and released in EP 4.6.1. |
Closed
1 task
Closed
1 task
Setting visibility of `$index` to protected as requested by @felipeelia .
|
@felipeelia thanks for the feedback and the inclusion of this in a future release. I updated as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a deprecation notice because the
$indexproperty is undeclared inElasticPress\Feature\WooCommerce\Ordersand created dynamically.Changelog Entry
Declared property
$indexin Orders.php in order to avoid the deprecation notice in PHP 8.2.Checklist: