Implement abstract Block facet feature class #3499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a next step, we could think about Both have implications specially in the original Facet feature block. We'll need to deprecate those parameters accordingly. |
oscarssanchez
changed the title
felipeelia
requested changes
Aug 3, 2023
There was a problem hiding this comment.
@oscarssanchez I've pushed a commit changing a few things but it seems we still need to change the check_facets_rest_permission call in other Block.php files. Also, do you mind calling me on slack to explain more about that $is_selected parameter? I remember we talked about it but now that I looked into it, it seems unnecessary.
…ticPress into feature/facet-abstract-classes
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR implements two abstract classes for the Facets feature. It tries to gather as many commonalities as possible from the facets so in the future, if we need to add subsequent Facet types, we can use the abstract classes as a guide to reduce developing times.
Closes #3472
How to test the Change
Changelog Entry
Credits
Props @oscarssanchez, @felipeelia
Checklist: