Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure get_elasticsearch_error_reason returns a string #3495

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Ensure get_elasticsearch_error_reason returns a string #3495

merged 1 commit into from
Jun 12, 2023

Conversation

felipeelia
Copy link
Member

The title says it all. This is really just a safety measure for any unknown return format.

@felipeelia felipeelia added this to the 4.6.0 milestone Jun 12, 2023
burhandodhy
burhandodhy approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@burhandodhy burhandodhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felipeelia felipeelia merged commit 9df3ab7 into develop Jun 12, 2023
@felipeelia felipeelia deleted the chore/ensure-string-return branch June 12, 2023 19:01
felipeelia added a commit that referenced this pull request Jun 13, 2023
@felipeelia
Add #3492, #3493, and #3495
a448844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burhandodhy burhandodhy burhandodhy approved these changes

Assignees

@burhandodhy burhandodhy

Labels
None yet
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@felipeelia @burhandodhy