Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of request errors #3483

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Better handling of request errors #3483

merged 1 commit into from
Jun 5, 2023

Conversation

felipeelia
Copy link
Member

@felipeelia felipeelia commented Jun 5, 2023 •
edited
Loading

Description of the Change

This PR fixes the PHP Warning: Trying to access array offset on value of type null in /var/www/html/wp-content/plugins/ElasticPress/includes/classes/Elasticsearch.php on line 865 error message that can be seen here, for example.

Changelog Entry

Fixed - Error message when the Elasticsearch server is not available during the put mapping operation

Credits

Props @felipeelia

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 4.6.0 milestone Jun 5, 2023
burhandodhy
burhandodhy approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@burhandodhy burhandodhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

burhandodhy
burhandodhy approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@burhandodhy burhandodhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felipeelia felipeelia merged commit e231de2 into develop Jun 5, 2023
@felipeelia felipeelia deleted the chore/error-return-handling branch June 5, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burhandodhy burhandodhy burhandodhy approved these changes

Assignees

@burhandodhy burhandodhy

Labels
None yet
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@felipeelia @burhandodhy