Facet by post type #3473
Merged
Facet by post type #3473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeelia
requested changes
May 31, 2023
There was a problem hiding this comment.
@oscarssanchez we will need to make some changes before merging this one. I was also expecting at least unit tests covering all the new filters. Do you think that would be possible? If not we can regroup and I can take this one over. We'll also need e2e tests for it.
Instead of `ep_post_type_filter_post_type`, changing it to be `ep_post_type_filter` instead
burhandodhy
reviewed
Jun 5, 2023
burhandodhy
reviewed
Jun 5, 2023
Co-authored-by: Burhan Nasir <burhandodhy@users.noreply.github.com>
burhandodhy
approved these changes
Jun 5, 2023
burhandodhy
previously approved these changes
Jun 5, 2023
|
I see the changelog that this was added in 4.6.0, but i don't see the facet widget or understand how to test this. Is this only in Instant Results? |
|
Hi @JiveDig, Facet by Post Type is only available as a Block when using the block editor. If you're using something like Classic Widgets then it will not be available, as the feature has not been implemented as a Widget. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR adds a facet by post type block widget similar to our Facet by Meta/Taxonomy/Meta Range ones.
Closes #3461
How to test the Change
1.- Have a couple of post types
2.- Add a facet by post type block
3.- Go to the front end.
4.- Faceting by post type should be applied
Changelog Entry
Credits
Props @oscarssanchez
Checklist: