Feature: Did you mean #3425
Merged
Feature: Did you mean #3425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeelia
reviewed
May 25, 2023
There was a problem hiding this comment.
@burhandodhy identified some changes we'll need to do but happy to talk about it next week.
Add option in feature WIP Improvements Minor changes Minor changes Add tests Minor changes
felipeelia
requested changes
Jun 2, 2023
There was a problem hiding this comment.
@burhandodhy Can we also please add some documentation about how people can use this feature?
felipeelia
requested changes
Jun 7, 2023
There was a problem hiding this comment.
@burhandodhy some final changes we'll need to make before this can be merged. We also need to add somewhere that code is required to display the suggestions. Thoughts?
Also, I just noticed that the feature is auto-activating on existing installations and that is not something we can do on a minor release. Steps to reproduce:
- 10updocker wp option patch delete ep_feature_settings did-you-mean
- git checkout develop
- git checkout feature/2089
felipeelia
reviewed
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR adds the 'Did you mean' functionality just like other search engines have. The algorithm on ES will detect any typos in the search term and based on the result, the most preferred term will be disabled. To add the functionality to the search page, the user has to call the function
\ElasticPress\Features::factory()->get_registered_feature( 'did-you-mean' )->get_suggestion();Closes #2089
How to test the Change
\ElasticPress\Features::factory()->get_registered_feature( 'did-you-mean' )->get_suggestion();on theme search template.This feature includes a setting that applies when the search results yield no matches.
Changelog Entry
Credits
Props @burhandodhy
Checklist: