Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Undefined array key 'displayCount' #3373

Merged
merged 3 commits into from
Mar 7, 2023
Merged

Fix: Undefined array key 'displayCount' #3373

merged 3 commits into from
Mar 7, 2023

Conversation

burhandodhy
Copy link
Contributor

Description of the Change

This PR fixes the issue where the Facet by taxonomy throws the error when its added as a classis widget.

Closes #

How to test the Change

  • Add Taxonym Facet in classic widget
  • Go to frontend and see there is no warning message.

Changelog Entry

Fixed - Undefined array key 'displayCount' error for facet

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@burhandodhy burhandodhy added this to the 4.5.0 milestone Mar 7, 2023
@felipeelia felipeelia assigned burhandodhy and unassigned felipeelia Mar 7, 2023
@felipeelia felipeelia merged commit ce53520 into develop Mar 7, 2023
@felipeelia felipeelia deleted the fix/undefined-indexes branch March 7, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipeelia felipeelia felipeelia requested changes

Assignees

@burhandodhy burhandodhy

Labels
None yet
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@burhandodhy @felipeelia