Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clear link to Facet by Meta Range block. #3364

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

JakePT
Copy link
Contributor

@JakePT JakePT commented Mar 3, 2023

Description of the Change

While implementing tests I discovered an issue where it wasn't possible to clear the Facet by Range filter, as adjusting the range to the full range was still applying a filter for any posts with that custom field. This PR adds a Clear link to the Facet by Meta Range block which clears the range filter entirely.

How to test the Change

  1. Add the Facet by Meta Range block.
  2. View an archive of posts with some posts containing the field used for the range, and some not. All posts should be displayed.
  3. Apply the range filter without any changes. Only posts with the field should be show.
  4. A clear link should appear on the Facet by Meta Range block. Clicking it should show all posts again.

Changelog Entry

N/A.

Credits

Props @JakePT

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@JakePT JakePT requested a review from felipeelia March 3, 2023 11:05
@JakePT JakePT added this to the 4.5.0 milestone Mar 3, 2023
@felipeelia felipeelia merged commit ed84487 into develop Mar 3, 2023
@felipeelia felipeelia deleted the fix/clear-range-facet branch March 3, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants