Fix: All public methods in Command class are treated as a wpcli command #3320
Conversation
burhandodhy
force-pushed
the
fix/3193
branch
from
55f1a13 to
1a9948f
Compare
There was a problem hiding this comment.
@burhandodhy asked for some changes on this one. Although I'm not a fan of introducing a whole new class to fix the original problem, I also see it being valid to separate concerns... 🤔
There was a problem hiding this comment.
In addition to the small change that still needs to be done here @burhandodhy, do you mind fixing the git conflict that arose? Thanks.
There was a problem hiding this comment.
@burhandodhy the conflict was not properly fixed (the new code was reverted.) So I took a deeper look into the code and it seems we still have some inconsistencies and breaking changes. Do you mind giving it another thorough review? Are you 100% sure this does not break any existing behavior including hooks? Thanks.
burhandodhy
force-pushed
the
fix/3193
branch
from
33612e6 to
ceb2d25
Compare
There was a problem hiding this comment.
@burhandodhy we are almost there. There is a change that didn't seem to be pushed and also I just remembered we need to change the --remove parameter here.
Description of the Change
This PR adds a new Helper class for WP CLI commands and move the public method to Helper class so that they will be not treated as CLI command
Closes #3193
How to test the Change
Changelog Entry
Credits
Props @burhandodhy
Checklist: