Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the elasticpress-facets style by handle #3306

Merged
merged 5 commits into from
Feb 15, 2023
Merged

Conversation

felipeelia
Copy link
Member

Description of the Change

As stated in #3287, we add the same style several times for Facets blocks. We already have that same CSS file already registered with the elasticpress-facets handle, so this PR uses that instead.

Closes #3287

Changelog Entry

Fixed - Facets styles not enqueued more than once

Credits

Props @felipeelia

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 4.5.0 milestone Feb 8, 2023
@JakePT JakePT self-requested a review February 10, 2023 03:40
Copy link
Contributor

@JakePT JakePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felipeelia Code is fine, but tests are failing pretty consistently, and I can replicate locally. Seems like it might just have something to do with the test window being smaller?

@felipeelia felipeelia merged commit 5ffc678 into develop Feb 15, 2023
@felipeelia felipeelia deleted the fix/issue-3287 branch February 15, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How can i remove inline css?
2 participants