Delete indices of unused Indexables on a full sync #3261
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Unfortunately, this PR ended up doing more than I anticipated. The main goal of it is to delete indices of features that are no longer enabled. That will happen only if a full sync is performed.
To have that done, I had to differentiate registered and enabled Indexables and also check which indices exist before a sync is started. With that list of indices, it is now possible to send the mapping of an inexistent index, so this PR covers that too.
It also adds an optional
--status
parameter to theget-indices
WP-CLI command. Note: This command outputs the list of indices related to the current site but they don't necessarily exist. Theget-cluster-indices
outputs the list of indices really present in the ES server.As I had some problems running Cypress tests on WSL I've also added some instructions to fix those issues.
Closes #3186
How to test the Change
Also
Index not present. Mapping sent
message.Changelog Entry
Credits
Props @felipeelia
Checklist: