Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add Autosuggest health check info if feature is active. #3247

Merged
merged 3 commits into from
Jan 5, 2023

Conversation

JakePT
Copy link
Contributor

@JakePT JakePT commented Jan 5, 2023

Description of the Change

Fixes an issue where the Autosuggest Site Health section would still appear, but with the wrong info, if the Autosuggest feature is not enabled.

How to test the Change

In Tools > Site Health the ElasticPress.io - Autosuggest section should only appear when the Autosuggest feature is active, and only contain info relevant to Autosuggest.

Changelog Entry

Fixed - An issue where the Autosuggest Site Health Info would contain incorrect information unrelated to Autosuggest.

Credits

Props @JakePT

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@JakePT JakePT self-assigned this Jan 5, 2023
@JakePT JakePT requested a review from felipeelia January 5, 2023 10:55
@JakePT JakePT force-pushed the fix/autosuggest-site-health branch from 343532b to 027f6a9 Compare January 5, 2023 10:56
@JakePT JakePT changed the base branch from release/4.4.1 to develop January 5, 2023 10:57
@felipeelia felipeelia added this to the 4.4.1 milestone Jan 5, 2023
@felipeelia felipeelia merged commit 51f300a into develop Jan 5, 2023
@felipeelia felipeelia deleted the fix/autosuggest-site-health branch January 5, 2023 12:11
felipeelia added a commit that referenced this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants