Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run a more performant query #3215

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Run a more performant query #3215

merged 1 commit into from
Dec 20, 2022

Conversation

felipeelia
Copy link
Member

@felipeelia felipeelia commented Dec 19, 2022

Description of the Change

This PR changes the query run to detect distinct meta fields, making it so we only get a limited number of fields. It also gets all public fields but only the explicitly allowed private fields.

Closes #3178 and closes #3168

How to test the Change

A site with a big database is needed. Adding the following snippet helps to avoid the transients usage:

add_filter( 'transient_ep_meta_field_keys_post', '__return_false' );
add_filter( 'transient_ep_meta_field_keys', '__return_false' );

Changelog Entry

Changed - Detection of indexable meta fields when visiting the sync and status report pages.

Credits

Props @felipeelia @paoloburzacca

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 4.4.1 milestone Dec 19, 2022
@felipeelia felipeelia self-assigned this Dec 19, 2022
@felipeelia felipeelia merged commit aeb5e67 into develop Dec 20, 2022
@felipeelia felipeelia deleted the feature/issue-3178 branch December 20, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove oembeds from meta keys SQL queries ElasticPress 4.4.0 issues
1 participant