Add Health Check Elasticsearch tests #3213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burhandodhy
changed the title
felipeelia
requested changes
Dec 19, 2022
There was a problem hiding this comment.
Great work on this one @burhandodhy. I left a couple of comments, do you mind taking a look? Thanks!
|
|
||
| $response = json_decode( $this->_last_response, true ); | ||
|
|
||
| $this->assertEquals( true, $response['success'] ); |
There was a problem hiding this comment.
Can we change this to
Suggested change
| $this->assertEquals( true, $response['success'] ); | |
| $this->assertTrue( $response['success'] ); |
Comment on lines
77
to
78
|
|
||
| remove_filter( 'ep_host', '__return_empty_string' ); |
There was a problem hiding this comment.
I think the test suite removes all filters in the end of each test execution (at least WP core does.) Do you mind testing if we really need to remove it @burhandodhy?
There was a problem hiding this comment.
The tests are working fine without removing the filters. Most of the tests involve removing the filters at the end. Do you mind if I remove remove_filters from all tests in a separate PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR adds the unit tests for the
HealthCheckElasticsearchhttps://github.com/10up/ElasticPress/blob/4.4.0/includes/classes/HealthCheck/HealthCheckElasticsearch.phpCloses #3054
How to test the Change
Changelog Entry
Credits
Props @burhandodhy
Checklist: