Improve CLI commands tests coverage #3202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burhandodhy
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR adds the new tests for the WP CLI commands. With this change, the coverage of commands is reached to 90%.
I made one change in the
put_mapping_helperinstead of returning false when the error happens. I update that withWP_CLI::errorso it stops the execution as soon as an error occurs.Also, this particular line
ElasticPress/includes/classes/Command.php
Line 1338 in 5d2dd65
Closes #3198 #3054
How to test the Change
Changelog Entry
Credits
Props @burhandodhy, @felipeelia
Checklist: